Re-submit bid adapter for AdUp Technology #4603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
The failed tests in CircleCI have nothing to do with our adapter. :( |
SteffenAnders
force-pushed
the
re-submit-aduptech-bid-adapter
branch
2 times, most recently
from
e5db9bb
to
acd26b8
Compare
|
rebased to master |
msm0504
approved these changes
Dec 18, 2019
There was a problem hiding this comment.
@SteffenAnders Changes LGTM and have removed the use of deprecated functions.
I have 1 suggestion, though. Noticed multiple lines (106, 159, 177) checking levels within an object before getting a value. The utils.deepAccess function could be used instead. The docs for it can be seen here.
SteffenAnders
force-pushed
the
re-submit-aduptech-bid-adapter
branch
from
acd26b8
to
859c1a6
Compare
|
Update:
|
sa1omon
pushed a commit
to CleanMediaNet/Prebid.js
that referenced
this pull request
Dec 19, 2019
tadam75
pushed a commit
to smartadserver/Prebid.js
that referenced
this pull request
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
The adapter already existed and worked but was removed because of compatibility problems with latest Prebid.js 3.0 release. With this pull request i want to re-submit our adapter with the required changes:
mediaTypes.banner.sizesutils.getTopWindowUrl()utils.getTopWindowReferrer()Test parameters
Maintainers
Other information
New PR for the docs: prebid/prebid.github.io#1692
Initial PR for the adapter: #2809
Initial PR for the docs: prebid/prebid.github.io#866